Skip to content

tools: welcome first-time contributors - #65533

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
panva:first-time-contributor-welcome
Aug 27, 2026
Merged

tools: welcome first-time contributors#65533
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
panva:first-time-contributor-welcome

Conversation

@panva

@panva panva commented Aug 25, 2026

Copy link
Copy Markdown
Member

Add contribution guidance and an advisory AgentScan warning for first-time pull request authors.

@panva
tools: welcome first-time contributors
1ee89c0 
Add contribution guidance and an advisory AgentScan warning for
first-time pull request authors.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added discuss Issues opened for discussions and feedbacks. tools Issues and PRs related to the tools directory. labels Aug 25, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 25, 2026
jasnell
jasnell approved these changes Aug 25, 2026
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a try to see if it's effective

@panva panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 25, 2026
MikeMcC399

This comment was marked as resolved.

Sign in to view

@panva

panva commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Perhaps flagging multiple PRs from FIRST_TIME_CONTRIBUTOR could be added to this workflow or to a follow-on change?

It can be a prose in the text. I wouldn't run expensive policy queries in this workflow. Please make a suggestion.

@MikeMcC399

MikeMcC399 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Perhaps flagging multiple PRs from FIRST_TIME_CONTRIBUTOR could be added to this workflow or to a follow-on change?

It can be a prose in the text. I wouldn't run expensive policy queries in this workflow. Please make a suggestion.

Thanks for the response! The text is fine for the first contribution, and if they have read the guidance, they shouldn't be submitting multiple PRs anyway.

I hadn't considered the cost of additional queries and I understand your concern.

So I'm not going to suggest a change after all!

@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 25, 2026
@Renegade334

Renegade334 commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Example run: nodejs/node-auto-test#100 (comment)

Example with positive agentscan: nodejs/node-auto-test#101 (comment)
@panva I think the indentation looks a bit janky?

(sorry for accidentally closing, was on the wrong tab 😞)

@Renegade334 Renegade334 reopened this Aug 25, 2026
@panva

panva commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Example with positive agentscan: nodejs/node-auto-test#101 (comment)

I'll reflow the caution block

@panva

panva commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

@Renegade334 can you test again?

@Renegade334

Renegade334 commented Aug 25, 2026

Copy link
Copy Markdown
Member

nodejs/node-auto-test#102 (comment)

LGTM!

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 0befff5 into nodejs:main Aug 27, 2026
16 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Landed in 0befff5

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2026
@panva
panva deleted the first-time-contributor-welcome branch August 27, 2026 10:22
@MikeMcC399

MikeMcC399 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Now that this has landed, we see in the first PR (65582) that it needs an approval to run:

image

I guess there is no way to avoid that.

@panva

This comment was marked as outdated.

Sign in to view
@panva

This comment was marked as outdated.

Sign in to view
@panva

panva commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@MikeMcC399 The workflow actually ran, didn't need approval but author_association was NONE for some reason and so it evaluated to a skip. Although now the API reports FIRST_TIME_CONTRIBUTOR so this may be a race condition in github's metadata between the event and the API.

@panva

panva commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

I've disabled the workflow for now while searching for a workaround.

@MikeMcC399

MikeMcC399 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

I'm also suspicious at the moment of GitHub results, as we've discussed in Slack concerning problems with cron jobs and cloning into Jenkins.

@panva

panva commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Ok, i'll re-enable the workflow and observe for a bit before following up with using gh api to query the PR author_association instead.

@MikeMcC399

This comment was marked as resolved.

Sign in to view
@panva

This comment was marked as resolved.

Sign in to view
@MikeMcC399

This comment was marked as resolved.

Sign in to view
@panva panva mentioned this pull request Aug 27, 2026
Open
@panva

panva commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Followup in #65592. I wouldn't fast-track it, if anything the two days will give us more opportunity to observe the behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@legendecas legendecas legendecas approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes
@trivikr trivikr trivikr approved these changes
@MikeMcC399 MikeMcC399 MikeMcC399 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. discuss Issues opened for discussions and feedbacks. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@panva @nodejs-github-bot @MikeMcC399 @Renegade334 @jasnell @legendecas @trivikr